Skip to content

bpo-42010: [docs] Clarify subscription of types#22822

Merged
gvanrossum merged 5 commits into
python:masterfrom
Fidget-Spinner:docs-subscripts
Oct 20, 2020
Merged

bpo-42010: [docs] Clarify subscription of types#22822
gvanrossum merged 5 commits into
python:masterfrom
Fidget-Spinner:docs-subscripts

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Oct 20, 2020

Copy link
Copy Markdown
Member

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but someone else should verify and merge.
This should have a news entry.

@Fidget-Spinner

Copy link
Copy Markdown
Member Author

A burb entry has been added, however the tests that were previously successful are now failing with the message "GitHub Actions has encountered an internal error when running your job.".

@terryjreedy

Copy link
Copy Markdown
Member

I don't know if this is a random glitch or a result of markup. I triggered rerun of the actions. Otherwise, try deleting markup.

@terryjreedy

Copy link
Copy Markdown
Member

That worked. It is nice that GHAs have an easy to find and use Re-run button that only re-runs the stuff in that action. Much better than re-running everything.

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thanks!

@gvanrossum gvanrossum merged commit 7cdf30f into python:master Oct 20, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-22840 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2020
(cherry picked from commit 7cdf30f)

Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 20, 2020
…22840)

(cherry picked from commit 7cdf30f)


Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>

Automerge-Triggered-By: GH:gvanrossum
@Fidget-Spinner Fidget-Spinner deleted the docs-subscripts branch October 21, 2020 01:32
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants